[webkit-reviews] review cancelled: [Bug 12290] SVGTextContentElement is missing all its DOM methods : [Attachment 17302] Initial patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has cancelled Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 12290: SVGTextContentElement is missing all its DOM methods
http://bugs.webkit.org/show_bug.cgi?id=12290

Attachment 17302: Initial patch
http://bugs.webkit.org/attachment.cgi?id=17302&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
This looks OK.	We talked over IRC about a nicer design for the QueryWalker
which used subclasses and specific variable names/methods instead of generic
query variables.  Possibly virtual methods or templates instead of a switch
statement.

You're currently working out the nextPosition stuff with Harrison.  When that's
done we can review your final patch.