[webkit-reviews] review granted: [Bug 15998] Abstract much of RMATCH into MatchStack functions : [Attachment 17291] abstract RMATCH into MatchStack functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 15 10:51:36 PST 2007


Sam Weinig <sam at webkit.org> has granted Eric Seidel <eric at webkit.org>'s request
for review:
Bug 15998: Abstract much of RMATCH into MatchStack functions
http://bugs.webkit.org/show_bug.cgi?id=15998

Attachment 17291: abstract RMATCH into MatchStack functions
http://bugs.webkit.org/attachment.cgi?id=17291&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
The typedef should not be necessary in c++.
+typedef struct matchframe {

nor should this explicit struct
+  struct matchframe* prevframe;

r=me.


More information about the webkit-reviews mailing list