[webkit-reviews] review granted: [Bug 15983] run-sunspider needs a --shark-cache option for L2 Cache miss profiling : [Attachment 17265] the fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 14 11:38:42 PST 2007


Sam Weinig <sam at webkit.org> has granted Eric Seidel <eric at webkit.org>'s request
for review:
Bug 15983: run-sunspider needs a --shark-cache option for L2 Cache miss
profiling
http://bugs.webkit.org/show_bug.cgi?id=15983

Attachment 17265: the fix
http://bugs.webkit.org/attachment.cgi?id=17265&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
Your indentation is off, we like to use 4 spaces, not 2.  Other than that.
r=me.  Please also remember to add a changelog.


More information about the webkit-reviews mailing list