[webkit-reviews] review denied: [Bug 15976] Throwing an exception within Database.transaction ASSERTs then crashes : [Attachment 17254] Proposed fix

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has denied Brady Eidson <beidson at apple.com>'s
request for review:
Bug 15976: Throwing an exception within Database.transaction ASSERTs then
crashes
http://bugs.webkit.org/show_bug.cgi?id=15976

Attachment 17254: Proposed fix
http://bugs.webkit.org/attachment.cgi?id=17254&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+	 m_transactionError = new SQLError(0, "the SQLTransactionCallback was
null or threw an exception");

Do we need to localize this string? Should "the" be capitalized? Where is this
text used?

It doesn't look like m_transactionError gets set everywhere
deliverTransactionErrorCallback() is called -- do we need to do it elsewhere?
What's the rule?

r- until there's a regression test (you should be able to turn the attached
testcase into a test pretty easily).