[webkit-reviews] review requested: [Bug 15938] Inspector/Qt requires patch to SecurityOrigin : [Attachment 17243] Add FrameLoader::shouldTreatSchemeAsLocal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 13 16:05:05 PST 2007

Holger Freyther <freyther at handhelds.org> has asked  for review:
Bug 15938: Inspector/Qt requires patch to SecurityOrigin

Attachment 17243: Add FrameLoader::shouldTreatSchemeAsLocal

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
Altnernative implementation. Add FrameLoader::shouldTreatSchemeAsLocal and call
it with KURL::protocol from within FrameLoader and SecurityOrigin when we have
a KURL. In CachedResource and Document we continue to use the
shouldTreatURLAsLocal function as we have (Deprecated)Strings there.

This function is doing the splitting of the URL first before it is comparing
file and http as fast path. And due not using .find in shouldTreatSchemeAsLocal
we need to check for the null string otherwise we end up with a crash in the

This introduces no regressions and I would welcome feedback and specially in
regard to Performance and Correctness.

More information about the webkit-reviews mailing list