[webkit-reviews] review granted: [Bug 15790] Ligatures aren't accounted for when manipulating VisiblePositions : [Attachment 17124] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 13 07:48:50 PST 2007


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 15790: Ligatures aren't accounted for when manipulating VisiblePositions
http://bugs.webkit.org/show_bug.cgi?id=15790

Attachment 17124: proposed fix
http://bugs.webkit.org/attachment.cgi?id=17124&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
It's a little ugly to be using caretRect for this purpose, but I think it's a
clever solution.

 497		     return offset() ==
textRenderer->nextOffset(textRenderer->previousOffset(offset()));
 498		 else
 499		     return thisRect !=
textRenderer->caretRect(textRenderer->previousOffset(offset()), UPSTREAM);

We normally don't do else after return.

r=me


More information about the webkit-reviews mailing list