[webkit-reviews] review granted: [Bug 15953] Add UTF-8
encoding/decoding to WTF : [Attachment 17201] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 12 21:25:03 PST 2007
Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 15953: Add UTF-8 encoding/decoding to WTF
http://bugs.webkit.org/show_bug.cgi?id=15953
Attachment 17201: proposed patch
http://bugs.webkit.org/attachment.cgi?id=17201&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
What exactly does JSStringCreateWithUTF8CString do if passed invalid UTF-8?
What should it do?
268 * This method should only be used for *debugging* purposes as it
269 * is not Unicode safe.
Perhaps that's overstating the case -- might there be some circumstances where
you know it's an all-ASCII UString?
Should we add a UTF-8 text decoder to WebCore that uses this? Maybe if we did
we could get rid of the simple/complex system for ICU, since we could handle
the most common encodings without creating much of a text encoding registry at
all. And perhaps we could change functions that convert to UTF-8 in
WebCore::String to not use the registry.
Looks good, r=me
More information about the webkit-reviews
mailing list