[webkit-reviews] review denied: [Bug 15955] WebCore should use
threading abstraction : [Attachment 17206] Reimplements
IconDatabase and SQLiteDatabase in terms of threading API
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 12 09:57:17 PST 2007
Brady Eidson <beidson at apple.com> has denied Justin Haygood
<jhaygood at reaktix.com>'s request for review:
Bug 15955: WebCore should use threading abstraction
http://bugs.webkit.org/show_bug.cgi?id=15955
Attachment 17206: Reimplements IconDatabase and SQLiteDatabase in terms of
threading API
http://bugs.webkit.org/attachment.cgi?id=17206&action=edit
------- Additional Comments from Brady Eidson <beidson at apple.com>
There's still the style-only tweaks I mentioned (re: parenthesis)
> #ifndef NDEBUG
>- memset(&m_openingThread, 0, sizeof(pthread_t));
>+ m_openingThread = 0;
> #endif
Since it's just an integral type now and we set m_openingThread(0) in the
initializer list, maybe we should just remove the #ifndef NDEBUG/#endif here.
More information about the webkit-reviews
mailing list