[webkit-reviews] review denied: [Bug 15745] [GTK] Arrow keys do not Scroll : [Attachment 17175] 0001-Handle-scrolling-for-Up-Down-Right-Left-in-WebKitPag.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 12 04:41:43 PST 2007


Alp Toker <alp at atoker.com> has denied Xan Lopez <xan.lopez at gmail.com>'s request
for review:
Bug 15745: [GTK] Arrow keys do not Scroll
http://bugs.webkit.org/show_bug.cgi?id=15745

Attachment 17175:
0001-Handle-scrolling-for-Up-Down-Right-Left-in-WebKitPag.patch
http://bugs.webkit.org/attachment.cgi?id=17175&action=edit

------- Additional Comments from Alp Toker <alp at atoker.com>
Will be good to get this fixed. However, the constant should be defined in one
place, if there needs to be a constant at all.

I think the correct fix is actually to use the scroll granularity and direction
enumerations just like the Win port does. Perhaps it's even just a
copy-and-paste job.


More information about the webkit-reviews mailing list