[webkit-reviews] review granted: [Bug 15939] Add currentThread API : [Attachment 17179] Implements currentThread API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 11 21:25:40 PST 2007

Adam Roben <aroben at apple.com> has granted Justin Haygood
<jhaygood at reaktix.com>'s request for review:
Bug 15939: Add currentThread API

Attachment 17179: Implements currentThread API

------- Additional Comments from Adam Roben <aroben at apple.com>
+static ThreadIdentifier identifierByPthreadHandle(pthread_t& pthreadhandle)

The parameter should be marked const (ditto for the ThreadingGtk version).

+    for (; i != threadMap().end(); ++i) {
+	 if (i->second == thread))
+	     return i->first;
+    }

You don't need the braces around the body of the loop.


More information about the webkit-reviews mailing list