[webkit-reviews] review granted: [Bug 14521] JavaScriptCore fails to build on Linux/PPC gcc 4.1.2 : [Attachment 17187] Possible patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has granted Mike Hommey
<mh+webkit at glandium.org>'s request for review:
Bug 14521: JavaScriptCore fails to build on Linux/PPC gcc 4.1.2
http://bugs.webkit.org/show_bug.cgi?id=14521

Attachment 17187: Possible patch
http://bugs.webkit.org/attachment.cgi?id=17187&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
There's two possible kinds of problems that can be caused by getting the
assembly operand constraints wrong:

1) Inferior codegen, due to overconstraining the operands, and forcing gcc to
do needless moves.

2) Incorrect codegen, de to using an operand that is disallowed.

I think #2 will make the assembly stage fail, so if PPC compiles with this
patch it should be safe. For #1, we should be ok as well, because m is a looser
constraint than o, so you'd never have a needless copy to satisfy m when o is
satisfied.

r=me