[webkit-reviews] review granted: [Bug 15896] More editing cleanup : [Attachment 17122] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 15896: More editing cleanup
http://bugs.webkit.org/show_bug.cgi?id=15896

Attachment 17122: proposed patch
http://bugs.webkit.org/attachment.cgi?id=17122&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
-int Node::maxOffset() const
+int Node::maxCharacterOffset() const
 {
-    return 1;
+    ASSERT_NOT_REACHED();
+    return 0;
 }

Could this be pure virtual?

+    return (int)m_data.length();

I'd prefer a C++ style cast.

r=me