[webkit-reviews] review granted: [Bug 15896] More editing cleanup : [Attachment 17122] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 10 12:40:41 PST 2007

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 15896: More editing cleanup

Attachment 17122: proposed patch

------- Additional Comments from Darin Adler <darin at apple.com>
-int Node::maxOffset() const
+int Node::maxCharacterOffset() const
-    return 1;
+    return 0;

Could this be pure virtual?

+    return (int)m_data.length();

I'd prefer a C++ style cast.


More information about the webkit-reviews mailing list