[webkit-reviews] review denied: [Bug 15813] Incorrect handling of findstr results in *.vcproj : [Attachment 17014] Fix handling results of findstr

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 10 09:11:20 PST 2007


Adam Roben <aroben at apple.com> has denied Matt Lilek <webkit at mattlilek.com>'s
request for review:
Bug 15813: Incorrect handling of findstr results in *.vcproj
http://bugs.webkit.org/show_bug.cgi?id=15813

Attachment 17014: Fix handling results of findstr
http://bugs.webkit.org/attachment.cgi?id=17014&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
I'm not sure how the new behavior is different from the old. Before we had:

if ERRORLEVEL 0 set EnablePREfast false else set EnablePREfast true

Now we have

if ERRORLEVEL 1 set EnablePREfast true else set EnablePREfast false

What is the difference?

I also don't think we want "echo on" in our pre-build step.


More information about the webkit-reviews mailing list