[webkit-reviews] review granted: [Bug 15924] next step in PCRE streamlining : [Attachment 17158] patch -- renames make it look *much* bigger than it is

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 9 18:08:30 PST 2007


Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 15924: next step in PCRE streamlining
http://bugs.webkit.org/show_bug.cgi?id=15924

Attachment 17158: patch -- renames make it look *much* bigger than it is
http://bugs.webkit.org/attachment.cgi?id=17158&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
One typo.  

+	 (jsRegExpExecute): Use new/free instead of pcre_malloc/free. Removed
unused
+	 start_match field from the match block.

You meant new/delete I believe.

There is also one place where you use fastMalloc/fastFree instead of
new/delete.  I am not sure if you want to make the change.

r=me.  You may want to test on windows first though.


More information about the webkit-reviews mailing list