[webkit-reviews] review denied: [Bug 15907] Implement USE(QT4_UNICODE) for UTF8 -> UTF16 conversion : [Attachment 17138] implements Qt 4 Unicode path in c_utility.cpp

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Justin Haygood
<jhaygood at reaktix.com>'s request for review:
Bug 15907: Implement USE(QT4_UNICODE) for UTF8 -> UTF16 conversion
http://bugs.webkit.org/show_bug.cgi?id=15907

Attachment 17138: implements Qt 4 Unicode path in c_utility.cpp
http://bugs.webkit.org/attachment.cgi?id=17138&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+    *UTF16Length = wcslen(utf16);

This won't work correctly if there are null characters in the string, and won't
even compile on platforms with a different definition of wchar_t (such as Mac
OS X).

I think it would be best to take code from
<http://www.unicode.org/Public/PROGRAMS/CVTUTF/ConvertUTF.c>, possibly throwing
away the ICU-based implementation.

Also, see the Latin-1 fallback code path in ICU branch - I think we'd like to
have it on all platforms.