[webkit-reviews] review requested: [Bug 15682] Move wx port to TOT : [Attachment 17136] wxWebKit API files (updated)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 8 17:59:56 PST 2007

Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 15682: Move wx port to TOT

Attachment 17136: wxWebKit API files (updated)

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
Addresses all the issues raised by Mark except for the switch to OwnPtr, as
we've been trying to avoid using WebKit specific elements in public header API.
This may change in the future, but the current code does delete the object fine
and so I think we can revisit this later. Many thanks to Mark for the detailed
review, he caught a lot of things I overlooked, particularly that strange 'ftp'
reference in there. 

Though, while I saw the reasoning for removing it, I kinda liked that the
browser reported that wxWebKit works... :)

More information about the webkit-reviews mailing list