[webkit-reviews] review denied: [Bug 15907] Implement USE(QT4_UNICODE) for UTF8 -> UTF16 conversion : [Attachment 17129] implements qt4 unicode in c_utility.cpp

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Justin Haygood
<jhaygood at reaktix.com>'s request for review:
Bug 15907: Implement USE(QT4_UNICODE) for UTF8 -> UTF16 conversion
http://bugs.webkit.org/show_bug.cgi?id=15907

Attachment 17129: implements qt4 unicode in c_utility.cpp
http://bugs.webkit.org/attachment.cgi?id=17129&action=edit

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
The patch needs a ChangeLog entry, and the coding style should follow the style
guidelines.  I know that the ICU code above does not, but it'd be great if new
code would.  In particular, the use of C-style casts, and the one-line for
statement with strange whitespace usage.