[webkit-reviews] review granted: [Bug 15653] [GTK] Text editor does not handle common keystrokes : [Attachment 16824] Implementation B

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 8 14:31:59 PST 2007


Mark Rowe (bdash) <mrowe at apple.com> has granted 's request for review:
Bug 15653: [GTK] Text editor does not handle common keystrokes
http://bugs.webkit.org/show_bug.cgi?id=15653

Attachment 16824: Implementation B
http://bugs.webkit.org/attachment.cgi?id=16824&action=edit

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
While this approach is suboptimal in the long run, the Gtk port is in need of
some form of sane input handling so that work on related features can progress.
 The ideal approach probably involves using GtkBindingSet which, as I
understand it, will respect user-customised key bindings and all that fancy
stuff.

r=me if a new bug is filed about switching to GtkBindingSet at some point in
the future, and the comment in the patch is updated to a FIXME referencing the
bug.


More information about the webkit-reviews mailing list