[webkit-reviews] review requested: [Bug 15790] Ligatures aren't accounted for when manipulating VisiblePositions : [Attachment 17124] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 8 11:00:41 PST 2007


Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 15790: Ligatures aren't accounted for when manipulating VisiblePositions
http://bugs.webkit.org/show_bug.cgi?id=15790

Attachment 17124: proposed fix
http://bugs.webkit.org/attachment.cgi?id=17124&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This fixes the test case... But I'm not sure about many things here, e.g.:

- Is this likely to negatively affect performance?
- This changes behavior WRT zero-width characters, which will now be ignored
when considering candidate positions.
- Is caretRect() the right way to compare coordinates?


More information about the webkit-reviews mailing list