[webkit-reviews] review requested: [Bug 15879] Add evaluateToNumber fast path for numeric operations : [Attachment 17106] Improved patch, 0.7% improvement for Sunspider

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 7 02:12:07 PST 2007


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 15879: Add evaluateToNumber fast path for numeric operations
http://bugs.webkit.org/show_bug.cgi?id=15879

Attachment 17106: Improved patch, 0.7% improvement for Sunspider
http://bugs.webkit.org/attachment.cgi?id=17106&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm more interested in comments than I am a +/-.  It think this patch could
probably still use some tweaking.

One thing I've considered is adding a non-virtual
inlineEvaluateToNumber(ExecState*) call to certain nodes, which both evaluate()
and evaluateToNumber() can use.  It would need to be a class method, which
hopefully the compiler would be smart enough to inline.  Maybe I should just
make it a static inline and pass "this" along, but then I'd need to improve the
exception macros and possibly other functions (which could be done).


More information about the webkit-reviews mailing list