[webkit-reviews] review granted: [Bug 15847] Some editing cleanup : [Attachment 17058] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 6 07:38:05 PST 2007


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 15847: Some editing cleanup
http://bugs.webkit.org/show_bug.cgi?id=15847

Attachment 17058: updated patch
http://bugs.webkit.org/attachment.cgi?id=17058&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	 return (NSString *)plainText(makeRange(startVisiblePosition,
endVisiblePosition).get());

Why is that typecast needed?

r=me

Another kind of editing cleanup we need is to move as much as possible of the
Mac-specific editing code in WebHTMLView into Editor and make it
platform-independent. There's some truly-platform-specific code there, but
there's more code that is there simply for historic reasons.


More information about the webkit-reviews mailing list