[webkit-reviews] review denied: [Bug 15409] FrameLoaderClientGtk hardcodes data, including platform to Linux i686 : [Attachment 17051] No more string abuse but clean concatenation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 5 17:16:29 PST 2007


Alp Toker <alp at atoker.com> has denied Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 15409: FrameLoaderClientGtk hardcodes data, including platform to Linux
i686
http://bugs.webkit.org/show_bug.cgi?id=15409

Attachment 17051: No more string abuse but clean concatenation
http://bugs.webkit.org/attachment.cgi?id=17051&action=edit

------- Additional Comments from Alp Toker <alp at atoker.com>
This patch returns an empty string for the UA on Release builds due to
uninitialised variables. I think it would be best to remove the "custom"
variables for now since they're not yet used.


More information about the webkit-reviews mailing list