[webkit-reviews] review granted: [Bug 15682] Move wx port to TOT : [Attachment 17010] wx platform impl. patch part #4, trunk build fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 3 08:15:18 PDT 2007

Mark Rowe (bdash) <mrowe at apple.com> has granted Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 15682: Move wx port to TOT

Attachment 17010: wx platform impl. patch part #4, trunk build fixes

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
r=me, with some minor style fixes.

In DragDataWx.cpp the include of DragData.h should be below config.h. 
Similarly, the ordering should be fixed in DragImageWx.cpp and

 in Widget::setCursor, the opening brace should be on the same line as the if
statement.  The inner if statement should probably be combined with the outer
if, and the explicit comparison to zero removed per the style guidelines.

More information about the webkit-reviews mailing list