[webkit-reviews] review denied: [Bug 15766] [GTK] WebKit spews flash/etc.. as text/plain into iframe if plugin missing : [Attachment 16982] Updated patch to fix one style issue and include a ChangeLog entry in header

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 2 10:44:18 PDT 2007


Mark Rowe (bdash) <mrowe at apple.com> has denied Rodney Dawes
<dobey at wayofthemonkey.com>'s request for review:
Bug 15766: [GTK] WebKit spews flash/etc.. as text/plain into iframe if plugin
missing
http://bugs.webkit.org/show_bug.cgi?id=15766

Attachment 16982: Updated patch to fix one style issue and include a ChangeLog
entry in header
http://bugs.webkit.org/attachment.cgi?id=16982&action=edit

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
For sake of compatibility I think you should match Windows and Mac in the
return value when the MIME type is empty.  A minor coding style nit that should
be fixed is the lack of whitespace around the + operator.  You should also
include your ChangeLog entry, with spaces instead of tabs for indentation, as
part of the diff.


More information about the webkit-reviews mailing list