[webkit-reviews] review granted: [Bug 15682] Move wx port to TOT :
[Attachment 16922] wx impl. for dragging and event handler
interfaces.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 1 13:46:35 PDT 2007
Adam Roben <aroben at apple.com> has granted Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 15682: Move wx port to TOT
http://bugs.webkit.org/show_bug.cgi?id=15682
Attachment 16922: wx impl. for dragging and event handler interfaces.
http://bugs.webkit.org/attachment.cgi?id=16922&action=edit
------- Additional Comments from Adam Roben <aroben at apple.com>
+#include "Frame.h"
+#include "Page.h"
+#include "FocusController.h"
+#include "FrameView.h"
+#include "KeyboardEvent.h"
+#include "MouseEventWithHitTestResults.h"
+#include "PlatformScrollBar.h"
+#include "RenderWidget.h"
+#include "ClipboardWx.h"
Please alphabetize the #includes.
+namespace WebCore
+{
The brace should go on the same line as "namespace".
+bool DragController::isCopyKeyDown()
+{
+ return false;
+}
Perhaps you want to call notImplemented() here?
r=me, but please fix the above before checking in.
More information about the webkit-reviews
mailing list