[webkit-reviews] review requested: [Bug 13919] Autogenerate the JS bindings for the CSSRule and its subclasses : [Attachment 14778] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 29 20:32:16 PDT 2007


Sam Weinig <sam at webkit.org> has asked  for review:
Bug 13919: Autogenerate the JS bindings for the CSSRule and its subclasses
http://bugs.webkit.org/show_bug.cgi?id=13919

Attachment 14778: patch
http://bugs.webkit.org/attachment.cgi?id=14778&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
The only part of this patch that I am not sure of is in CSSRule.idl where I
special cased JS for the cssText attribute.  The hand rolled bindings had the
attribute as readonly, but the spec and ObjC bindings don't have this
restriction.  On the otherhand, we don't really support it in the
implementation so the issue is rather insignificant.  A similar issue (but in
the other direction) is CSSCharsetRule.idl.



More information about the webkit-reviews mailing list