[webkit-reviews] review requested: [Bug 13890] [gdk] Use a
GtkLayout for the ScrollView implementation to get real
scrollbars : [Attachment 14745] Make ScrollView a scrollable view
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 26 19:04:33 PDT 2007
Holger Freyther <freyther at handhelds.org> has asked for review:
Bug 13890: [gdk] Use a GtkLayout for the ScrollView implementation to get real
scrollbars
http://bugs.webkit.org/show_bug.cgi?id=13890
Attachment 14745: Make ScrollView a scrollable view
http://bugs.webkit.org/attachment.cgi?id=14745&action=edit
------- Additional Comments from Holger Freyther <freyther at handhelds.org>
Without the ChangeLog entries one would see that less lines of code are needed
to implement scrollbars properly. Please review, meanwhile I plan to valgrind
and search for CodingStyle issues myself as well.
WebCore/ChangeLog | 49 +++++++++
WebCore/platform/ScrollView.h | 12 +-
WebCore/platform/gdk/FrameGdk.cpp | 87 +---------------
WebCore/platform/gdk/ScrollViewGdk.cpp | 147
+++++++++++++---------------
WebCore/platform/gdk/TemporaryLinkStubs.cpp | 8 -
WebCore/platform/gdk/WidgetGdk.cpp | 52 ++++++++-
WebKitTools/ChangeLog | 14 ++
WebKitTools/GdkLauncher/main.cpp | 53 ++++++----
8 files changed, 231 insertions(+), 191 deletions(-)
More information about the webkit-reviews
mailing list