[webkit-reviews] review denied: [Bug 13828] x/y values on rootmost <svg> elements should be ignored : [Attachment 14724] First attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 25 16:34:40 PDT 2007


Oliver Hunt <oliver at apple.com> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 13828: x/y values on rootmost <svg> elements should be ignored
http://bugs.webkit.org/show_bug.cgi?id=13828

Attachment 14724: First attempt
http://bugs.webkit.org/attachment.cgi?id=14724&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
i find myself wondering whether
else {
+	     rootX += x().value();
+	     rootY += y().value();
	 }
should account for tx, ty

though the more i think about the less i think it should.. hmmm...

also the += can just be + now


fianlly, the layout test in this case can *probably* be text only... eg.
eventController.dumpAsText
or somthing



More information about the webkit-reviews mailing list