[webkit-reviews] review requested: [Bug 13456] REGRESSION:
setTimeout "arguments" object gets shadowed by a local
variable (Can't get past splash screen for KLM airlines) :
[Attachment 14721] Fix by explicitly checking for arguments
in VarDeclNode::evaluate
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 25 07:17:33 PDT 2007
Kimmo Kinnunen <kimmok at iki.fi> has asked for review:
Bug 13456: REGRESSION: setTimeout "arguments" object gets shadowed by a local
variable (Can't get past splash screen for KLM airlines)
http://bugs.webkit.org/show_bug.cgi?id=13456
Attachment 14721: Fix by explicitly checking for arguments in
VarDeclNode::evaluate
http://bugs.webkit.org/attachment.cgi?id=14721&action=edit
------- Additional Comments from Kimmo Kinnunen <kimmok at iki.fi>
The solution is not so nice because it uses explicit check. the error might
show up somewhere else and of course if new similar properties are added to
function call scope, same kind of bug will occur. Also the patch has has longer
comment part than the actual code part.
At least it gives a hint on why the bug exists..
More information about the webkit-reviews
mailing list