[webkit-reviews] review granted: [Bug 13825] [CAIRO] Implement PathCairo : [Attachment 14682] Implement PathCairo, take three

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 24 19:23:21 PDT 2007

Oliver Hunt <oliver at apple.com> has granted Alp Toker <alp at atoker.com>'s request
for review:
Bug 13825: [CAIRO] Implement PathCairo

Attachment 14682: Implement PathCairo, take three

------- Additional Comments from Oliver Hunt <oliver at apple.com>
you could
#define notImplemented() ASSERT(!"Not implemented");

for non gdk cairo...
I believe all platforms have ASSERT

I would be tempted to say that you shoud add CairoPath.h to define the
CairoPath struct, and then include that file, that should minimise changes to
the platform header.

But otherwise r=me

More information about the webkit-reviews mailing list