[webkit-reviews] review granted: [Bug 13830] Auto-generate JS DOM bindings for HTMLDocument and most of the rest of HTMLElement : [Attachment 14692] Updated JSHTMLDocument patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 13830: Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement
http://bugs.webkit.org/show_bug.cgi?id=13830

Attachment 14692: Updated JSHTMLDocument patch
http://bugs.webkit.org/attachment.cgi?id=14692&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	 return toJS(exec, node);
+    } else if (!collection->length())
+	 return jsUndefined();

No need for an else here. It would also be nice not to call
collection->length() twice.

+	 // FIXME: Create an [NoOp] property for legacy functions that do
nothing like this.

I don't agree that we want to do this. Lets keep the binding layer as simple as
possible. I know it's complicated, but lets not make it more complicated except
for when we have to.

r=me