[webkit-reviews] review requested: [Bug 13830] Auto-generate JS DOM
bindings for HTMLDocument and most of the rest of HTMLElement
: [Attachment 14692] Updated JSHTMLDocument patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 23 11:43:47 PDT 2007
Sam Weinig <sam at webkit.org> has asked for review:
Bug 13830: Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement
http://bugs.webkit.org/show_bug.cgi?id=13830
Attachment 14692: Updated JSHTMLDocument patch
http://bugs.webkit.org/attachment.cgi?id=14692&action=edit
------- Additional Comments from Sam Weinig <sam at webkit.org>
Updated patch addresses most of Darin's comments. I have left location() and
setLocation() as custom because they both deal with JS related concepts in
appropriate for the implementation. I also did not make the function clear()
non-custom because doing so would interfere with the function Document.clear()
already in the implementation.
I have not addressed Alexey's comment as I would like to do that in a
separate patch.
More information about the webkit-reviews
mailing list