[webkit-reviews] review granted: [Bug 13830] Auto-generate JS DOM bindings for HTMLDocument and most of the rest of HTMLElement : [Attachment 14674] Just the JSHTMLElement

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 13830: Auto-generate JS DOM bindings for HTMLDocument and most of the rest
of HTMLElement
http://bugs.webkit.org/show_bug.cgi?id=13830

Attachment 14674: Just the JSHTMLElement
http://bugs.webkit.org/attachment.cgi?id=14674&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
-	 case ElementInnerText:
-	     impl()->document()->updateLayoutIgnorePendingStylesheets();
-	     return jsString(element.innerText());

I see that innerText calls it if renderer() is non-0, but can it sometimes make
renderer be non-0? If so, then this changes behavior.

+		  // So we use don't convert null to JS null.

I think you need to omit the word "use" here. It would be even easier to
understand if you mentioned the attribute that we're not using.

r=me