[webkit-reviews] review denied: [Bug 13842] Simplify Color::light() and Color::dark() : [Attachment 14684] Simpler implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 23 07:57:12 PDT 2007

Darin Adler <darin at apple.com> has denied mitz at webkit.org's request for review:
Bug 13842: Simplify Color::light() and Color::dark()

Attachment 14684: Simpler implementation

------- Additional Comments from Darin Adler <darin at apple.com>
Does this really give the same values as before? If so, seems fine. But I was
under the impression that scaling value didn't affect the 3 channels equally.

I don't think dark() properly handles the case where all three of r, g, and b
are zero. So review- because of that. Otherwise, would be r=me.

More information about the webkit-reviews mailing list