[webkit-reviews] review denied: [Bug 13825] [CAIRO] Implement PathCairo : [Attachment 14663] Implement PathCairo, take two

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Alp Toker <alp at atoker.com>'s request
for review:
Bug 13825: [CAIRO] Implement PathCairo
http://bugs.webkit.org/show_bug.cgi?id=13825

Attachment 14663: Implement PathCairo, take two
http://bugs.webkit.org/attachment.cgi?id=14663&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I'm looking at this and i don't like the need to have different handling  of
the PlatformPath, and currently it looks like you're begging for memory leaks.

i would suggest
typedef struct cairopath { 
    cairo_t* m_context; 
    cairopath() {
	cairo_surface_t* pathSurface =
cairo_image_surface_create(CAIRO_FORMAT_A8, 1, 1);
	m_cr = cairo_create(pathSurface);
	moveTo(FloatPoint(0, 0));
    }
    ~cairopath() {
	//appriate delete stuff
    }
} PlatformPath;

then do everything in terms of that, that way you don't need ifdefs in the
actual definition part of the header. 

This is an ugly ugly byproduct of cairo's borked path api :-/

It's far to similar to the canvas api for my liking :-(