[webkit-reviews] review denied: [Bug 13174] line-height in font shorthand does not override a previously stated line-height property : [Attachment 14641] First attempt

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 13174: line-height in font shorthand does not override a previously stated
line-height property
http://bugs.webkit.org/show_bug.cgi?id=13174

Attachment 14641: First  attempt
http://bugs.webkit.org/attachment.cgi?id=14641&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Per conversation on IRC, I suggested just always making line-height be mapped
in as one of the first properties like font.

However instead of going into the RenderStyle in the switch statement it would
just be cached as a member variable on the style selector.

After the style has been determined (e.g., around the time adjustRenderStyle is
going to get called), that line height value (if it exists) should be mapped in
for real.