[webkit-reviews] review granted: [Bug 13565] Change svn-create-patch to put LayoutTests in the end : [Attachment 14633] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 20 00:26:51 PDT 2007

Adam Roben <aroben at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 13565: Change svn-create-patch to put LayoutTests in the end

Attachment 14633: Patch v1

------- Additional Comments from Adam Roben <aroben at apple.com>
+	 In addition reordering non-binary files under the LayoutTests
directory, this

Typo: "In addition" -> "In addition to"

+	 $dir = File::Spec->catdir($dirs[0], ".svn") if -d $dirs[0];
+	 $dir = File::Spec->catdir(dirname($dirs[0]), ".svn") if -f $dirs[0];

It would be nice not to repeat the catdir call -- can you put the directory
name in a local and then call catdir?

+# Generate the diff for text files, layout files then binary files for easy

"layout files" is a confusing term (and "layoutFiles" is a similarly misleading
variable name). Perhaps "test files"/"testFiles" would be more appropriate?


More information about the webkit-reviews mailing list