[webkit-reviews] review denied: [Bug 13599] Scripts to generate coverage information for WebKit : [Attachment 14613] Patch to add CoverageTools

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 19 16:13:33 PDT 2007

Mark Rowe (bdash) <bdash at webkit.org> has denied Holger Freyther
<freyther at handhelds.org>'s request for review:
Bug 13599: Scripts to generate coverage information for WebKit

Attachment 14613: Patch to add CoverageTools

------- Additional Comments from Mark Rowe (bdash) <bdash at webkit.org>
Code like:
die unless (system "...") eq 0;

feels quite unnatural.	It would read better if it were:
system("..") == 0 or die;

Is it really necessary to do find . -name '*.gc*' at the top of the WebKit
source tree?  Are the *.gc* files not limited to certain directories?  Even if
not, omitting LayoutTests from the search path would make this step a bit

+my $resultName = $svnVersion."-".join('_', @timeData);
Whitespace between operators would be great.

Other than these stylistic issues I see no major issues.

More information about the webkit-reviews mailing list