[webkit-reviews] review granted: [Bug 13320] rounded corners with drop shadows are really slow : [Attachment 14626] Use a single rounded rect path

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 19 09:58:38 PDT 2007


Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 13320: rounded corners with drop shadows are really slow
http://bugs.webkit.org/show_bug.cgi?id=13320

Attachment 14626: Use a single rounded rect path
http://bugs.webkit.org/attachment.cgi?id=14626&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
In Path::createRoundedRectangle I would expect you to use float insted of
double. FloatRect, etc. are actually "float" not double, and converting back
and forth can be costly.

Otherwise looks great. r=me



More information about the webkit-reviews mailing list