[webkit-reviews] review requested: [Bug 13782] REGRESSION (r21528-r21533): Failing editing/selection/drag-in-iframe in pixel mode : [Attachment 14618] Fix for bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 18 18:47:59 PDT 2007

Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 13782: REGRESSION (r21528-r21533): Failing editing/selection/drag-in-iframe
in pixel mode

Attachment 14618: Fix for bug

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Whoops, the r21533 patch required holding on to a DOMElement for the duration
of the drag in order to produce promised content.  To avoid keeping an entire
Document around ad infinitum i explicitly cleared the pasteboard after the
drag.  This doesn't work well with DRT, and tim suggests other apps may behave
similarly to DRT, so i've removed the pastebaord clearing.

Most of this patch is basically replacing a domelement reference with the
underlying CachedImage instead.

More information about the webkit-reviews mailing list