[webkit-reviews] review granted: [Bug 13732] patch to make prepare-ChangeLog work with git : [Attachment 14568] More complete git support for prepare-ChangeLog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 15 16:42:12 PDT 2007

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben
<aroben at apple.com>'s request for review:
Bug 13732: patch to make prepare-ChangeLog work with git

Attachment 14568: More complete git support for prepare-ChangeLog

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Overall this patch looks great!  I assume you've been living on it for a while,

A couple comments:

- Shouldn't %svn in isModifiedOrAddedStatus() also contain "R" for replaced

- Using diffHeaderFormat() within loops (when it returns the same value each
time) and redefining local data structures for each method call (like in
isModifiedOrAddedStatus() and isConflictStatus() and statusDescription()) makes
me cringe, but unless there is an apparent slow down, it's nice not to have to
declare global variables that are farther away from the subroutines.

- I understand the reason for declaring $isSVN, $isGit and $gitRoot next to
their methods, but I'm torn about not having them at the top of the script,
too.  They're okay, though.

r=me if you address "R" in %svn in isModifiedOrAddedStatus().

More information about the webkit-reviews mailing list