[webkit-reviews] review granted: [Bug 10878] Incorrect decompilation for "4..x" : [Attachment 14543] Improved testcases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 14 06:47:26 PDT 2007

Darin Adler <darin at apple.com> has granted Kimmo Kinnunen <kimmok at iki.fi>'s
request for review:
Bug 10878: Incorrect decompilation for "4..x"

Attachment 14543: Improved testcases 

------- Additional Comments from Darin Adler <darin at apple.com>
Please also don't use tabs in your patches. We don't use tabs and whoever goes
to land your changes will have to replace them with spaces so Subversion will
accept the patch.

This is very thorough. Great!

I think it would be even better if the test case output reflected the test
cases instead of just f1 through f6. To do that you need to structure the test
so the strings you pass to shouldBe contain the interesting part of the test.

More information about the webkit-reviews mailing list