[webkit-reviews] review requested: [Bug 13275] Safari crashed when trying to login using the windows live contact control : [Attachment 14535] Patch (no layout test)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 13 06:54:47 PDT 2007


Andrew Wellington <proton at wiretapped.net> has asked  for review:
Bug 13275: Safari crashed when trying to login using the windows live contact
control
http://bugs.webkit.org/show_bug.cgi?id=13275

Attachment 14535: Patch (no layout test)
http://bugs.webkit.org/attachment.cgi?id=14535&action=edit

------- Additional Comments from Andrew Wellington <proton at wiretapped.net>
This fixes the problem as the XMLHttpRequest returns after the window has been
destroyed, causing a null dereference.

I'm not sure how (or if it's possible) to make a layout test for this: we need
to have an xmlhttprequest return data after a window has already been
destroyed. Pointers as to how (if possible) to do a layout test would be great.



More information about the webkit-reviews mailing list