[webkit-reviews] review granted: [Bug 10878] Incorrect decompilation for "4..x" : [Attachment 14489] Second try, address the comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 11 08:13:10 PDT 2007

Darin Adler <darin at apple.com> has granted Kimmo Kinnunen <kimmok at iki.fi>'s
request for review:
Bug 10878: Incorrect decompilation for "4..x"

Attachment 14489: Second try, address the comments

------- Additional Comments from Darin Adler <darin at apple.com>

I noticed that the test case doesn't cover all the code. For example, there are
many lines of code in nodes2string.cpp that you could delete without breaking
any test case. I suggest making an even better test case that covers every
single case at some point, but no need to do this before landing this.

Typo: "formating".

More information about the webkit-reviews mailing list