[webkit-reviews] review requested: [Bug 13572] Arabic characters are not correctly joined when using Arial : [Attachment 14488] Add a private stripped-down version of u_shapeArabic that handles the non-Arabic languages

[bugzilla-daemon at webkit.org]

mitz at webkit.org has asked  for review:
Bug 13572: Arabic characters are not correctly joined when using Arial
http://bugs.webkit.org/show_bug.cgi?id=13572

Attachment 14488: Add a private stripped-down version of u_shapeArabic that
handles the non-Arabic languages
http://bugs.webkit.org/attachment.cgi?id=14488&action=edit

------- Additional Comments from mitz at webkit.org
(In reply to comment #14)
> (From update of attachment 14476 [edit])
> I'm surprised by the function name. In what way is this Macintosh-specific?

I removed "Mac" from the function and file names, but I left them in the
platform/mac
subdirectory, since this code is not cross-platform (and in that sense it is
Macintosh-specific). I really hope this hack can be removed in the future.

> I don't think we need to use U_CAPI and U_EXPORT2 in an internal WebCore
> header.

Fixed.

> Typically we capitalize filenames, so I would call this ShapeArabicMac.h/cpp.


Fixed.