[webkit-reviews] review granted: [Bug 13675] Focus rings don't
repaint properly on editable continuations : [Attachment
14485] Patch with layout test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 11 02:27:14 PDT 2007
Oliver Hunt <oliver at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 13675: Focus rings don't repaint properly on editable continuations
http://bugs.webkit.org/show_bug.cgi?id=13675
Attachment 14485: Patch with layout test
http://bugs.webkit.org/attachment.cgi?id=14485&action=edit
------- Additional Comments from Oliver Hunt <oliver at apple.com>
+ if (table->isEmpty())
+ return;
+
+ RenderFlowSequencedSet* continuations = table->get(this);
+ if (!continuations)
+ return;
is the isEmpty() check necessary given we also check the result of get?
Looks good, i'd like you to run the pixel tests though, and (you'll hate me for
this) manually check any pixel tests that fail
More information about the webkit-reviews
mailing list