[webkit-reviews] review requested: [Bug 13667] REGRESSION (r21363):
Focus ring too tall : [Attachment 14478] Fix focus rings for
continuations to account for collapsing through other blocks
when inlines are empty
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 10 16:08:19 PDT 2007
Dave Hyatt <hyatt at apple.com> has asked for review:
Bug 13667: REGRESSION (r21363): Focus ring too tall
http://bugs.webkit.org/show_bug.cgi?id=13667
Attachment 14478: Fix focus rings for continuations to account for collapsing
through other blocks when inlines are empty
http://bugs.webkit.org/attachment.cgi?id=14478&action=edit
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
A block in the middle of a continuation should only include its collapsed
margins if they aren't going to collapse beyond the inlines above/below.
This is covered by existing layout tests (even the test I added to fix the
original bug showed this problem, I just didn't notice it), sigh.
This is purely a pixel issue, so isn't caught except by pixel layout tests.
More information about the webkit-reviews
mailing list