[webkit-reviews] review requested: [Bug 13344] pdf file is getting opened in a new window using adobe plugin : [Attachment 14407] New patch for this issue and issue #10015 regarding plugins

[bugzilla-daemon at webkit.org]

Madhu M <madhu.mukund at wipro.com> has asked  for review:
Bug 13344: pdf file is getting opened in a new window using adobe plugin
http://bugs.webkit.org/show_bug.cgi?id=13344

Attachment 14407: New patch for this issue and issue #10015 regarding plugins
http://bugs.webkit.org/attachment.cgi?id=14407&action=edit

------- Additional Comments from Madhu M <madhu.mukund at wipro.com>
I am submitting a new patch for this issue. In this I am following the (2)
method in my previous comment. Please see the details below

If the 'type' attribute is having wrong value, it is getting validated and the
correct value is being set to 'serviceType' from the data attribute. So the
parameter serviceType is ensured to have a correct value. But after this, if
the 'paramNames' include type and a wrong value in 'paramValues', the plugin is

getting opened in a new window. The serviceType seems to be getting overridden
by this value.

To solve this there are two ways.

1. Remove the type from the paramNames and its value from the paramValues, once

type is set to 'serviceType'. (I have followed this in my previous patch).

2. Set the correct value of type in 'paramValues' from 'serviceType'.(This
method is followed in this patch).

Could you please review this and give comments ?