[webkit-reviews] review requested: [Bug 13578] When QD plugins draw to an offscreen bitmap the origin is not correct : [Attachment 14404] respect the origin implied by the bitmap contexts affine tranformation matrix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 7 16:29:39 PDT 2007


Bruce Q. Hammond <bruceq at apple.com> has asked  for review:
Bug 13578: When QD plugins draw to an offscreen bitmap the origin is not
correct
http://bugs.webkit.org/show_bug.cgi?id=13578

Attachment 14404: respect the origin implied by the bitmap contexts affine
tranformation matrix
http://bugs.webkit.org/attachment.cgi?id=14404&action=edit

------- Additional Comments from Bruce Q. Hammond <bruceq at apple.com>
Implements the changes requested by reviewers to go though
CGPointApplyAffineTransform to create the origin data.	Personally I don't like
this patch as much as the previous one because it requires yet another call to
CGPointApplyAffineTransform in order to determine if the axes are flipped. 
However it is simply a mater of taste and is functionally identical;  it may be
more clear to some maintainers what is happening.
I also now treat Y-Axis and and X-Axis identically even though inverting the
X-Axis would be unusual.



More information about the webkit-reviews mailing list