[webkit-reviews] review granted: [Bug 13304] REGRESSION(14784): WebKit doesn't dynamically reflect changes to the highlight color in System Preferences : [Attachment 14358] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 5 15:15:29 PDT 2007


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 13304: REGRESSION(14784): WebKit doesn't dynamically reflect changes to the
highlight color in System Preferences
http://bugs.webkit.org/show_bug.cgi?id=13304

Attachment 14358: proposed fix
http://bugs.webkit.org/attachment.cgi?id=14358&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    static RenderThemeMac* macTheme;
+    if (!macTheme)
+	 macTheme = new RenderThemeMac;

This could just be written:

    static RenderThemeMac* macTheme = new RenderThemeMac;

The initialization only runs once.

r=me



More information about the webkit-reviews mailing list